Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide clearer error if no LOP path is set on USD render ROP #82

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Provide clearer error if no LOP path is set on USD render ROP #82

merged 3 commits into from
Sep 5, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Aug 28, 2024

Changelog Description

Provide clearer error if no LOP path or an invalid path is set on USD render ROP

image

Additional info

Fixes #71

Testing notes:

  1. Create USD Render instance
  2. Set no LOP path or invalid LOP path
  3. Publish, validation should be nice.

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Aug 28, 2024
@BigRoy BigRoy self-assigned this Aug 28, 2024
@BigRoy BigRoy requested a review from moonyuet September 5, 2024 15:03
moonyuet
moonyuet approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. When the usd render instance doesn't set the render settings, it would error out. If yes, it won't.
And the message looks more concise to guide users to add the render setting/render product nodes before publishing.
image
image

@BigRoy BigRoy merged commit d770cf6 into ynput:develop Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonyuet moonyuet moonyuet approved these changes

@MustafaJafar MustafaJafar Awaiting requested review from MustafaJafar

Assignees

@BigRoy BigRoy

Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publishing usdrender without LOP path set raises confusing error on collect
2 participants
@BigRoy @moonyuet